Skip to content

fix (de)ser of FileLines between lib and cli opt #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

fix (de)ser of FileLines between lib and cli opt #3954

merged 1 commit into from
Dec 9, 2019

Conversation

calebcartwright
Copy link
Member

Resolves #3649

@calebcartwright calebcartwright mentioned this pull request Dec 5, 2019
Closed
topecongiro
topecongiro approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@topecongiro topecongiro merged commit cc0b060 into rust-lang:master Dec 9, 2019
@calebcartwright calebcartwright deleted the file-lines-json-spans branch December 9, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@topecongiro topecongiro topecongiro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileLines::all().to_json_spans() returns [] which is parsed as empty map
3 participants
@calebcartwright @topecongiro @karyon