Skip to content

ci: configure max concurrent GHA jobs #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2020
Merged

ci: configure max concurrent GHA jobs #4134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a3baa7
chore: remove config/emitter cargo aliases
calebcartwright Apr 21, 2020
16bca79
ci: add max-parallel config to workflows
calebcartwright Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .cargo/config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@ test-all = "test --manifest-path rustfmt-core/Cargo.toml"
test-bin = "test --manifest-path rustfmt-core/rustfmt-bin/Cargo.toml"
tb = "test-bin"

test-config = "test --manifest-path rustfmt-core/rustfmt-config/Cargo.toml"
tc = "test-config"

test-emitter = "test --manifest-path rustfmt-core/rustfmt-emitter/Cargo.toml"
te = "test-emitter"

test-lib = "test --manifest-path rustfmt-core/rustfmt-lib/Cargo.toml"
tl = "test-lib"

Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ jobs:
runs-on: ubuntu-latest
name: ${{ matrix.integration }}
strategy:
# https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits
# There's a limit of 60 concurrent jobs across all repos in the rust-lang organization.
# In order to prevent overusing too much of that 60 limit, we throttle the
# number of rustfmt jobs that will run concurrently.
max-parallel: 4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all told these config changes should limit us to a max of 7 concurrent jobs (per trigger) which should be fine for our purposes. I wish that GitHub supported this config as a repository setting instead of it being scoped to each individual matrix, but perhaps one day...

fail-fast: false
matrix:
integration: [
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ jobs:
runs-on: ubuntu-latest
name: (${{ matrix.target }}, ${{ matrix.channel }}, ${{ matrix.cfg-release-channel }})
strategy:
# https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits
# There's a limit of 60 concurrent jobs across all repos in the rust-lang organization.
# In order to prevent overusing too much of that 60 limit, we throttle the
# number of rustfmt jobs that will run concurrently.
max-parallel: 1
fail-fast: false
matrix:
target: [
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ jobs:
runs-on: windows-latest
name: (${{ matrix.target }}, ${{ matrix.channel }})
strategy:
# https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits
# There's a limit of 60 concurrent jobs across all repos in the rust-lang organization.
# In order to prevent overusing too much of that 60 limit, we throttle the
# number of rustfmt jobs that will run concurrently.
max-parallel: 1
fail-fast: false
matrix:
target: [
Expand Down