Skip to content

Align string type for edition #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from May 23, 2020
Merged

Align string type for edition #4197

merged 1 commit into from May 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2020

Writing 2018 for the edition, like it suggests it results in

Error: Decoding config file failed:
invalid type: integer `2018`, expected string for key `edition`
Please check your config file.

So just like other strings, make it sure it has to be a string

@topecongiro topecongiro merged commit fd1362a into rust-lang:master May 23, 2020
@topecongiro
Copy link
Contributor

Thanks!

@ghost ghost deleted the patch-1 branch May 23, 2020 15:23
bradleypmartin pushed a commit to bradleypmartin/rustfmt that referenced this pull request May 25, 2020
Align string type for edition (rust-lang#4197)
20a52b7
@karyon
Copy link
Contributor

karyon commented Oct 28, 2021

backported in #4623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1x-backport:completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topecongiro @karyon