Issue4392 resolution - No new line after operation #4397
Conversation
There was a problem hiding this comment.
Thank you for the PR @davidBar-On. However, this is not currently in a mergeable state, and is most likely just a compounding of an underlying formatting failure due to the comments.
Please again note that the CI checks are failing with your changes. You may want to take a look at the documentation on testing rustfmt again (links below), and please feel free to reach out with any questions here and/or on Discord
https://github.com/rust-lang/rustfmt/blob/master/Contributing.md#creating-test-cases
https://github.com/rust-lang/rustfmt/blob/master/Contributing.md#running-tests
| /* Trim white spaces at end of lines */ | ||
| let mut c = String::from(""); | ||
| for line in snippet.to_owned().split('\n') { | ||
| if c != "" { | ||
| c.push('\n') | ||
| }; | ||
| c.push_str(line.trim_end()); | ||
| } | ||
| Some(c.to_owned()) |
There was a problem hiding this comment.
You've got these same changes in three separate PRs. Please keep various commits and changes separate for easier review and potential for merging.
As I noted in #4391 (comment), I do not believe this is the right approach to address the related issue.
| }; | ||
| let list_len = list.list.len(); | ||
| /* ???? Is there better way than transmute() ???? */ | ||
| let list_expr = unsafe { std::mem::transmute::<&T, &ast::Expr>(e) }; |
There was a problem hiding this comment.
As noted on the other thread, there's a root problem with comments between the subexpr and type in cast expressions which is most certainly impacting the formatting you are seeing with your snippets.
We really need to focus on the addressing the core issue instead of associated items, especially an approach like this as there are currently no unsafe blocks within the rustfmt source to my knowledge.
|
OK, Thanks. I now see that the root issue may be related to the issues discussed in the other thread, so this issue should be retested after the other issues are solved. Regarding the repeated changes this was unintentional and I will try to make sure that doesn't happen (unless the same change is part of solving different issues). |
For issue #4392 resolution - not adding new line after operation ('==', etc.).
Also test cases file is added.
An issue in the code changes is that "transmute" is used. Hopefully there is better way to implement.