Skip to content

Change directory name in test_merged_config test #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

Change directory name in test_merged_config test #4409

merged 1 commit into from
Sep 3, 2020

Conversation

mgrachev
Copy link
Contributor

@mgrachev mgrachev commented Sep 2, 2020

Fix #4405

@mgrachev
Copy link
Contributor Author

mgrachev commented Sep 2, 2020 •
edited
Loading

I have broken all tests 🙈 😅

@calebcartwright
Copy link
Member

I have broken all tests see_no_evil sweat_smile

No worries, that's unrelated to the changes here. Try rebasing to grab the latest changes from master

@mgrachev
Copy link
Contributor Author

mgrachev commented Sep 2, 2020

No worries, that's unrelated to the changes here. Try rebasing to grab the latest changes from master

Thank you! All tests are passed 🙌

topecongiro
topecongiro approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@topecongiro topecongiro merged commit 4e72871 into rust-lang:master Sep 3, 2020
@mgrachev mgrachev deleted the patch-1 branch September 3, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topecongiro topecongiro topecongiro approved these changes

Assignees
No one assigned
Labels
backport-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directory name used by test_merged_config is not rust unique
4 participants
@mgrachev @calebcartwright @topecongiro @karyon