ci: GHA Workflow Updates #4527
Merged
ci: GHA Workflow Updates #4527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
commented
Nov 15, 2020
Comment on lines
-40
to
-53
| # The Windows runners do not (yet) have a proper msys/mingw environment | ||
| # pre-configured like AppVeyor does, though they will likely be added in the future. | ||
| # https://github.com/actions/virtual-environments/issues/30 | ||
| # | ||
| # In the interim, this ensures mingw32 is installed and available on the PATH | ||
| # for the i686-pc-windows-gnu target. This approach is used because it's common in | ||
| # other rust projects and there are issues/limitations with the msys2 chocolatey nuget | ||
| # package and numworks/setup-msys2 action. | ||
| # https://github.com/rust-lang/rust/blob/master/src/ci/scripts/install-mingw.sh#L59 | ||
| # https://github.com/rust-lang/rustup/blob/master/appveyor.yml | ||
| # | ||
| # Use GitHub Actions cache support to avoid downloading the .7z file every time | ||
| # to be cognizant of the AWS egress cost impacts | ||
| # https://help.github.com/en/actions/automating-your-workflow-with-github-actions/caching-dependencies-to-speed-up-workflows#usage-limits-and-eviction-policy |
There was a problem hiding this comment.
MSYS2 has subsequently been added to the Actions runners so all the mingw tooling is available for the i686-pc-windows-gnu target
|
backported in #4525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only run workflows on pushes to
master, and do some mingw cleanup on Windows