Replace match expression with match! macro #5034
Conversation
src/lists.rs
Outdated
| @@ -15,6 +15,7 @@ use crate::utils::{ | |||
| unicode_str_width, | |||
| }; | |||
| use crate::visitor::SnippetProvider; | |||
| use DefinitiveListTactic::*; | |||
There was a problem hiding this comment.
There's a lot of overlap in variant names with other enums (e.g. ListTactic and SeparatorTactic) so we probably don't want to have a wildcard import globally as subsequent usage makes it hard in some cases to know which is which.
It'd be fine to use this locally within the function/before the matches! call since scoping (and proximity) makes it much more obvious, but if not locally, then I'd prefer to just have the patterns called out explicitly with the full enum variant in the matches! call
There was a problem hiding this comment.
Sure. When I saw your comment on the previous PR I just assumed you meant to move the use statement to the top of the file, but if it's fine to keep it locally scoped then I'll make that change!
This is a follow up to 5f4811e The matches! macro expresses the condition more succinctly and avoids the extra level of indentation introduced with the match arm body.
ytmimi
force-pushed
the
cleanup_issue_4615
branch
from
25c2b14 to
c35c0db
Compare
This is a follow up to 5f4811e
The
matches!macro expresses the condition more succinctly and avoidsthe extra level of indentation introduced with the match arm body.