-
Notifications
You must be signed in to change notification settings - Fork 928
enable filtered test file execution #5265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for the PR. I'm not inherently opposed to supporting more targeted testing for system tests, though to be honest I'm not quite sure what the motivation is. Typically we'll just run |
I tried to use
I use TEST_FILE=5250 to just execute a single test, but also print some debug info. Since I'm not familiar with the codebase, this helps me to understand what path the code takes. |
e.g. to execute all files containing 5250 TEST_FILE=5250 cargo test system
@calebcartwright, I think the main benefit would be running the test files with the correct configuration after Granted if someone is unfamiliar with the test suite they might not be aware that we're parsing the @PSeitz I don't think
If it helps, here's my typical workflow when fixing bugs or implementing features:
Not the most sophisticated, but it's gotten me pretty far :) |
Gotcha. We've got an additional special mechanism for config options in system/idempotence test files that we intentionally don't pick up as part of Will think on this a bit more, but I can see the potential utility now |
Yes, overall I think there are too many manual steps in comparison to
Merging this and documenting it in CONTRUBUTING.md imo would make the start easier for contributors. Even better would be |
Agreed, you've sold me on the need for something like this, I just wish we could find a way to make it work in a manner that's more consistent/fluid with how tests are filtered elsewhere via the more standard libtest models. Will take a look at the approach over the next few days but anticipate we'll move forward in some shape or another |
e.g. to execute all files containing 5250
TEST_FILE=5250 cargo test system