Skip to content

Enable rustfmt to compile when using the generic-simd feature #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Aug 2, 2023

Fixes #5859

In addition to the fix, CI is updated to hopefully avoid this issue moving forward.

r? @calebcartwright

ytmimi added 2 commits August 2, 2023 09:34
Bumping bytecount from `0.6.2` -> `0.6.3` allows rustfmt to properly
build when using the `generic-simd` feature.
Previously we were only building rustfmt with default features in CI. We
recently received a report that rustfmt was unable to compile with the
`generic-simd` feature, which is not enabled by default. To prevent a
similar situation in the future we'll start build nightly rustfmt with
all features enabled.
@calebcartwright
Copy link
Member

I'm going to skip flagging this for relnotes as it seems highly unlikely to be a source of any unanticipated changes, but let's keep a mental note of this in case we see some unexpected formatting changes that could be related

@calebcartwright calebcartwright merged commit 641d4f5 into rust-lang:master Aug 13, 2023
@ytmimi ytmimi deleted the issue_5859 branch August 13, 2023 23:25
@ytmimi
Copy link
Contributor Author

ytmimi commented Aug 13, 2023

@calebcartwright I'm now realizing that I don't actually know how rustfmt is built in the r-l/rust repo. Is it built with all features? If not then I'm guessing this isn't a change that would mess with formatting.

@calebcartwright
Copy link
Member

I actually don't know off hand (though I feel like I should!). I would imagine it's specified somewhere in the bootstrap code in the r-l/rust repo (perhaps in combination with some of the CI files), but I was just making a mental note of this as any time we change dependencies used in things like formatting or config loading behavior there's typically some non-zero chance of impact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build failure
3 participants