Remove empty list imports #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Format up to last newline | ||
| let last_pos = self.last_pos; | ||
| let span = codemap::mk_sp(last_pos, item.span.lo); | ||
| let snippet = self.codemap.span_to_snippet(span).unwrap(); |
|
Looks good other than the snippet nit |
|
@marcusklaas sorry this took so long to merge - GitHub doesn't send notifications when you push, only when you comment, so you need to ping me when you update the PR (or it will take me weeks to notice :-( ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes imports of the form
use std::convert::{};.