fix(clippy1): Trigger approx_constant lint rule instead of downgraded float_cmp. #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x_constant lint rule closes rust-lang#888
manyinsects
approved these changes
Dec 16, 2021
|
@all-contributors please add @frvannes16 for code |
|
@diannasoreil I've put up a pull request to add @frvannes16! 🎉 |
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
fix(clippy1): Trigger approx_constant lint rule instead of downgraded float_cmp.
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
fix(clippy1): Trigger approx_constant lint rule instead of downgraded float_cmp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes clippy1 for newer versions of Rust. When ran on rustc v1.57.0, clippy1 would pass without any changes. This was because the lint rule that clippy1 relies on (
float_cmp) was recently downgraded.This PR changes clippy1 and its hint to use a different lint rule:
approx_constant. Seeapprox_constantlint rule.To satisfy clippy for this exercise, users must change line 14:
to
closes #888