Skip to content

upgrading from non-profiles rustup to profiles rustup should auto-add profile= in settings.toml just like first time install does #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Oct 8, 2019 · 0 comments · Fixed by #2050

Comments

@ghost
Copy link

ghost commented Oct 8, 2019

Describe the problem you are trying to solve

if rustup update will pull a rustup which now has profiles support, the profile= key/value in ~/.rustup/settings.toml will not be added(presumably, I haven't actually tested xD).

Describe the solution you'd like

I dno.

Notes

A side effect of not having profile= set in settings.toml is that you can't install any specific nightly version, as seen here

Workaround is running rustup set profile or rustup set profile minimal, the former sets profile = default in ~/.rustup/settings.toml and the latter sets profile = minimal which seems to match the non-profiles version of rustup that just got upgraded.

Also note that any/all comments in settings.toml are removed by running rustup set profile, or more specifically this code

@ghost ghost added the enhancement label Oct 8, 2019
@ghost ghost mentioned this issue Oct 8, 2019
@ghost ghost changed the title upgrading from non-profiles rustup to profiles rustup should auto-add profiles= in settings.toml just like first time install does upgrading from non-profiles rustup to profiles rustup should auto-add profile= in settings.toml just like first time install does Oct 8, 2019
kinnison added a commit to kinnison/rustup that referenced this issue Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants