rustup suggest executing "source ...", but this command is absent in dash

[safinaskar]

Problem

Command curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh in the end suggest running command source "$HOME/.cargo/env". But there is no command source in dash (this is Debian's default shell). So, please fix your suggestion to . instead of source.

I copied this source "$HOME/.cargo/env" from rustup output and pasted to my dockerfile. And docker build failed, because of this problem

Steps

.

Possible Solution(s)

No response

Notes

No response

Rustup version

.

Installed toolchains

.

[rbtcollins]

It is true that source is a bash extension, not POSIX. I worry that the . won't be particularly clear or visible to developers that haven't spent a lot of time in the intricacies of shell programming.

Perhaps we should make this less programmatic and instead say something like 'you need to source the environment file . Some common ways to do this are '. ' and 'source ', ...' and then we can add more for zsh and ion and all the other shells that are out there.

[rami3l]

@safinaskar After some research I found two heredoc strings that look suspicious. Could you please confirm whether they are the suggestions that you were seeing?

rustup/src/cli/self_update.rs

Lines 218 to 231 in bd08d35

	#[cfg(not(windows))]
	macro_rules! post_install_msg_unix {
	() => {
	r#"# Rust is installed now. Great!
	To get started you may need to restart your current shell.
	This would reload your `PATH` environment variable to include
	Cargo's bin directory ({cargo_home}/bin).
	To configure your current shell, run:
	source "{cargo_home}/env"
	"#
	};
	}

rustup/src/cli/self_update.rs

Lines 246 to 258 in bd08d35

	#[cfg(not(windows))]
	macro_rules! post_install_msg_unix_no_modify_path {
	() => {
	r#"# Rust is installed now. Great!
	To get started you need Cargo's bin directory ({cargo_home}/bin) in your `PATH`
	environment variable. This has not been done automatically.
	To configure your current shell, run:
	source "{cargo_home}/env"
	"#
	};
	}

[safinaskar]

@rami3l . I just executed curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh in fresh Docker container. Here is output it prints:

Rust is installed now. Great!

To get started you may need to restart your current shell.
This would reload your PATH environment variable to include
Cargo's bin directory ($HOME/.cargo/bin).

To configure your current shell, run:
source "$HOME/.cargo/env"

[rami3l]

@safinaskar Thanks!

I'm looking at the right place then. Should be an easy fix...

[rami3l]

It is true that source is a bash extension, not POSIX. I worry that the . won't be particularly clear or visible to developers that haven't spent a lot of time in the intricacies of shell programming.

Perhaps we should make this less programmatic and instead say something like 'you need to source the environment file . Some common ways to do this are '. ' and 'source ', ...' and then we can add more for zsh and ion and all the other shells that are out there.

@rbtcollins
Most "modern" shells support source, including csh, bash, zsh, fish, ion, etc.

Personally I use fish, but since it cannot parse the env file (cc #478, #3108), I chose to add the PATH manually, so we are probably back to POSIX vs bash grounds.

That being said, I have the same concern as yours: the dot will be easily overlooked by beginners who don't know . is a command, so I recommend that we keep the current suggestion, and add something like:

source might need to be replaced with . on some shells like ash, dash, or pdksh.

[safinaskar]

When https://sh.rustup.rs link will be updated? I want to test whether this bug is fixed

[rami3l]

@safinaskar Hi! The change is in the Rust part of rustup, so I'm afraid you have to wait for the next release. However, I've tested the change myself, both manually and automatically, and it works pretty well on my machine.

[safinaskar]

New version of rustc just released, but when I run curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh, I still see source ...

[rami3l]

@safinaskar The version of Rust (currently 1.73.0) has nothing to do with the version of rustup (currently 1.26.0). That being said, we are considering cutting a new release (possibly 1.27.0) at #3501. Please stay tuned!

FWIW, if you want to see what has been changed, you can see for yourself directly at https://github.com/rust-lang/rustup/pull/3445/files.

[rami3l]

Update: The prompt has again been polished with #3506.