Skip to content

for toolchains without cargo, set up environment to match rustc, not cargo #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2019
Merged

for toolchains without cargo, set up environment to match rustc, not cargo #2108

merged 1 commit into from
Nov 3, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 3, 2019

This implements the suggestion by @ehuss for how to fix #1575.

kinnison
kinnison approved these changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the recommendation AIUI. Thank you Ralf.

@kinnison kinnison merged commit 3e177e6 into rust-lang:master Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kinnison kinnison kinnison approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling of rustc-sysroot .so files differs when sysroots do not come with their own cargo
2 participants
@RalfJung @kinnison