Demote deprecation #2162
Merged
Demote deprecation #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expect_not_stderr_ok() implementation incorrectly expected an error. This commit introduces expect_not_stderr_err() for that specific case, and fixes the test in expect_not_stderr_ok() Signed-off-by: Daniel Silverstone <[email protected]>
These tests actually wanted to be expect_not_stderr_err Signed-off-by: Daniel Silverstone <[email protected]>
So that we can send simple verbose messages at runtime, add a plain verbose notification message type. Signed-off-by: Daniel Silverstone <[email protected]>
We decided that the deprecation messages ought to be verbose messages (i.e. only in --verbose mode) rather than warnings. Fixes: rust-lang#2149 Signed-off-by: Daniel Silverstone <[email protected]>
Signed-off-by: Daniel Silverstone <[email protected]>
Somehow sometimes we still get ETXTBSY on Travis test suite runs This attempts to mitigate that a little more Signed-off-by: Daniel Silverstone <[email protected]>
|
I'd recommend reviewing this commit-by-commit because there's a bunch of cleanups in here too, to support the goal. |
kinnison
commented
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rearranges things a little to fix #2149 and tries to mitigate the ETXTBSY situation a little more.