Add license note for VS Build Tools #2989
Conversation
doc/src/installation/windows.md
Outdated
| Visual Studio 2013 (or later) or the Visual C++ Build Tools 2019][vs] so | ||
| `rustc` can use its linker. For Visual Studio, make sure to check the "C++ | ||
| Visual Studio 2013 (or later)][vs] so `rustc` can use its linker and libraries. | ||
| Visual Studio Community is free for free for students, open-source contributors, |
There was a problem hiding this comment.
| Visual Studio Community is free for free for students, open-source contributors, | |
| Visual Studio Community is free for students, open-source contributors, |
I'm a little uncomfortable with this sentence explaining its terms, and I personally would just leave it out. The terms are quite a bit more complex (such as being free for any open-source work, visual studio extensions, drivers, academic research, teaching, non-enterprise up to 5 users, etc.).
Also, I'm not entirely sure I understand the argument about removing the link to Build Tools. Microsoft themselves recommends it.
Perhaps, instead of this change, we can add a note similar to the wording on Microsoft's installation page that reminds the user needs a valid license?
There was a problem hiding this comment.
That part is roughly the same as one from the page you linked ("A Community edition is available—it's free for students, open-source contributors, and individuals").
I was worried that saying "this requires a license" on it own would imply it always requires payment. But for sure I could just revert this and add the note about needing license.
There was a problem hiding this comment.
Ok, I've change this PR so that it simply notes that the Build Tools have additional license requirements.
ChrisDenton
changed the title
|
Thank you for adding this :) |
Co-authored-by: Jonathan 'theJPster' Pallant <[email protected]>
This PR adds a note about the Visual Studio Build Tools needing a Visual Studio Community, Pro or Enterprise license.
A future improvement might be to create an expanded section on the different options. Perhaps that walks through the requirements and the installation process.
Fixes #2867