Windows: Improve handling of Visual Studio errors #3004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the user can always sees Visual Studio install errors even if the console closes when rustup-init exits. Also turn errors into warnings if the VS installer returned a non-zero exit code but all necessary components were installed.
ChrisDenton
force-pushed
the
show-vs-nonzero
branch
from
048b59c to
60d75df
Compare
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user the option to continue the rustup install even if installing Visual Studio fails. This also makes sure the user can always see Visual Studio install errors even if the console closes when rustup-init exits.
Also continue the install if the VS installer returned a non-zero exit code but all necessary components were installed successfully. This will still report the error to the user.