clippy::needless_borrow: Apply clippy suggestions #3200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo clippy` suggests removal of borrows in a number of locations. Seems like the standard library has changed to allow for borrows to be omitted on the result of `format!` and in a few other cases. https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow `CONTRIBUTING.md` suggests one runs this, before publishing a change: ```bash cargo clippy --all --all-targets --all-features -- -D warnings` ``` But, at the moment, this command generated more than a thousand warnings for me on `master`. This particular warning is responsible for about 50 cases. This change is just `cargo clippy --fix`, with flags to only show `clippy::needless_borrow`, followed by `cargo fmt`.
|
Duplicate of #3199 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo clippysuggests removal of borrows in a number of locations. Seems like the standard library has changed to allow for borrows to be omitted on the result offormat!and in a few other cases.https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
CONTRIBUTING.mdsuggests one runs this, before publishing a change:cargo clippy --all --all-targets --all-features -- -D warnings`But, at the moment, this command generated more than a thousand warnings for me on
master.This particular warning is responsible for about 50 cases.
This change is just
cargo clippy --fix, with flags to only showclippy::needless_borrow, followed bycargo fmt.