Skip to content

Avoid installing protoc for most CI workflows #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Avoid installing protoc for most CI workflows #3447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6b90ff
Avoid installing protoc for most CI workflows
djc Aug 16, 2023
dab4516
Authenticate when installing protoc
djc Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/all-features.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
uses: arduino/setup-protoc@v1
with:
version: "3.x"
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Set environment variables appropriately for the build
run: |
echo "$HOME/.cargo/bin" >> $GITHUB_PATH
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/centos-fmt-clippy-on-all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ jobs:
run: |
rustup component add rustfmt
rustup component add clippy
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
version: '3.x'
- name: Run the centos check within the docker image
run: |
docker run \
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/linux-builds-on-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,6 @@ jobs:
echo "DOCKER=$DOCKER" >> $GITHUB_ENV
- name: Fetch the docker
run: bash ci/fetch-rust-docker.bash "${TARGET}"
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
version: '3.x'
- name: Maybe build a docker from there
run: |
if [ -f "ci/docker/$DOCKER/Dockerfile" ]; then
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/linux-builds-on-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ jobs:
echo "DOCKER=$DOCKER" >> $GITHUB_ENV
- name: Fetch the docker
run: bash ci/fetch-rust-docker.bash "${TARGET}"
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
version: '3.x'
- name: Maybe build a docker from there
run: |
if [ -f "ci/docker/$DOCKER/Dockerfile" ]; then
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/linux-builds-on-stable.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,6 @@ jobs:
echo "DOCKER=$DOCKER" >> $GITHUB_ENV
- name: Fetch the docker
run: bash ci/fetch-rust-docker.bash "${TARGET}"
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
version: '3.x'
- name: Maybe build a docker from there
run: |
if [ -f "ci/docker/$DOCKER/Dockerfile" ]; then
Expand Down
4 changes: 0 additions & 4 deletions ci/actions-templates/centos-fmt-clippy-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ jobs:
run: |
rustup component add rustfmt
rustup component add clippy
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
version: '3.x'
- name: Run the centos check within the docker image
run: |
docker run \
Expand Down
4 changes: 0 additions & 4 deletions ci/actions-templates/linux-builds-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,6 @@ jobs:
echo "DOCKER=$DOCKER" >> $GITHUB_ENV
- name: Fetch the docker
run: bash ci/fetch-rust-docker.bash "${TARGET}"
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
version: '3.x'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  with:
    repo-token: ${{ secrets.GITHUB_TOKEN }}

Seems like the canonical approach to avoid rate limiting, from the setup-protoc repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this in another commit to all-features.yaml.

- name: Maybe build a docker from there
run: |
if [ -f "ci/docker/$DOCKER/Dockerfile" ]; then
Expand Down