Simplify toolchain construction #3880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
simplify-toolchain-construction
branch
3 times, most recently
from
8089215 to
4a60df3
Compare
rami3l
reviewed
Jun 17, 2024
rami3l
reviewed
Jun 17, 2024
rami3l
reviewed
Jun 17, 2024
1 task
rami3l
approved these changes
Jun 17, 2024
djc
force-pushed
the
simplify-toolchain-construction
branch
from
4a60df3 to
00ead82
Compare
djc
force-pushed
the
simplify-toolchain-construction
branch
2 times, most recently
from
cde3ceb to
f47f675
Compare
djc
force-pushed
the
simplify-toolchain-construction
branch
from
f47f675 to
5cc4002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another grab bag of refactoring that tries to improve cohesion in the system, oriented around how
Toolchains get created.