fix(dist): throw an error when a PartialVersion string doesn't start with an ASCII digit
#3895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with an ASCII digit
djc
approved these changes
Jun 20, 2024
rami3l
force-pushed
the
fix/partial-version-starts-with-digit
branch
2 times, most recently
from
fac4782 to
00bb133
Compare
rami3l
force-pushed
the
fix/partial-version-starts-with-digit
branch
from
00bb133 to
3e476d2
Compare
rami3l
force-pushed
the
fix/partial-version-starts-with-digit
branch
from
3e476d2 to
08a0cc2
Compare
djc
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3892.
There is a logical bug in the previous implementation of
PartialVersion::from_str: the parser will happily accept inputs like^1.0exactly because it was intended to be used that way (to parse version comparators instead of partial versions), it's just that it happens to have no effect thanks to where it's called in the current codebase. I think fixing it will make me feel safer :)