Use read_timeout for reqwest instead of timeout
#4218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update lib.rs
ChrisDenton
changed the title
read_timeout for reqwest instead of timeout
2 tasks
djc
approved these changes
Mar 4, 2025
|
For people landing on this issue because they can't update to 1.28.1 because of this error, try setting the environment variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClientBuilder::timeoutmethod applies to the whole download. Having 30s to complete a download seems very wrong so I assume the intent was to only timeout if the download stalls for that long, which is whatread_timeoutdoes.It might also be worth increasing the timeout to a minute or two for people with unreliable internet connections but I'm less sure that's needed.
Fixes #4213