Skip to content

ci(windows): enable full test suite for ARM64 build #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Apr 16, 2025

@rami3l rami3l force-pushed the ci/windows-arm64-full branch 2 times, most recently from 586c6b5 to 5f06b9f Compare April 16, 2025 02:39
@rami3l rami3l marked this pull request as draft April 16, 2025 02:59
@rami3l rami3l force-pushed the ci/windows-arm64-full branch from 5f06b9f to e817b73 Compare April 16, 2025 03:06
@rami3l

This comment was marked as resolved.

@rami3l rami3l force-pushed the ci/windows-arm64-full branch from e817b73 to 50f03e9 Compare April 16, 2025 05:37
@rami3l rami3l force-pushed the ci/windows-arm64-full branch 2 times, most recently from 90ead2d to c6b4e1e Compare April 16, 2025 05:46
@rami3l rami3l requested review from djc and ChrisDenton April 16, 2025 05:49
@rami3l rami3l marked this pull request as ready for review April 16, 2025 05:51
@rami3l rami3l force-pushed the ci/windows-arm64-full branch from c6b4e1e to cfa5b5c Compare April 16, 2025 05:59
@rami3l
Copy link
Member Author

rami3l commented Apr 16, 2025

Our compatibility with Windows ARM64 seems to be quite good: the full test suite has passed for a few times in a row.

@rami3l rami3l force-pushed the ci/windows-arm64-full branch from cfa5b5c to 3695807 Compare April 16, 2025 06:05
@rami3l
Copy link
Member Author

rami3l commented Apr 16, 2025

I can think of one potential risk of merging this PR: there could be a slight possibility that aws is not installed on this new machine... I'll use a quick droppable delta to verify this.


Update: Good news! It's actually installed already:

Run Get-Command aws
  Get-Command aws
  aws --version
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    RUSTFLAGS: -Ctarget-feature=+crt-static
    RUST_MIN_STACK: 16777216

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     aws.exe                                            0.0.0.0    C:\Program Files\Amazon\AWSCLIV2\aws.exe
aws-cli/2.24.8 Python/3.12.6 Windows/11 exe/ARM64

https://github.com/rust-lang/rustup/actions/runs/14490128412/job/40644490076?pr=4290

@rami3l rami3l marked this pull request as draft April 16, 2025 10:05
@rami3l rami3l force-pushed the ci/windows-arm64-full branch 2 times, most recently from 3f9297f to 3695807 Compare April 16, 2025 10:07
@rami3l rami3l marked this pull request as ready for review April 16, 2025 10:07
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our compatibility with Windows ARM64 seems to be quite good: the full test suite has passed for a few times in a row.

That's great to hear! I think for rustup problems with platform detection would be the main thing likely to be affected by an ARM64 host but it seems that's not an issue.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@djc djc added this pull request to the merge queue Apr 16, 2025
Merged via the queue into rust-lang:master with commit 52fce89 Apr 16, 2025
58 checks passed
@rami3l rami3l deleted the ci/windows-arm64-full branch April 16, 2025 13:46
@rami3l
Copy link
Member Author

rami3l commented Apr 16, 2025

I think for rustup problems with platform detection would be the main thing likely to be affected by an ARM64 host but it seems that's not an issue.

@ChrisDenton Thanks for pointing that out; to be frank I'm not quite sure the platform detection is good though, it looks like when we install rustup in this CI everything is hardcoded, and I don't quite remember if we have tests on platform detection.

That said, I've heard from a few users about their experience on ARM64 and I'm not aware of anything about that yet either.


Update: Someone has obviously done that testing manually on their machine when adding support for ARM64 Windows: #3010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants