-
Notifications
You must be signed in to change notification settings - Fork 951
ci(windows): enable full test suite for ARM64 build #4290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
586c6b5
to
5f06b9f
Compare
5f06b9f
to
e817b73
Compare
This comment was marked as resolved.
This comment was marked as resolved.
e817b73
to
50f03e9
Compare
90ead2d
to
c6b4e1e
Compare
c6b4e1e
to
cfa5b5c
Compare
Our compatibility with Windows ARM64 seems to be quite good: the full test suite has passed for a few times in a row. |
cfa5b5c
to
3695807
Compare
I can think of one potential risk of merging this PR: there could be a slight possibility that Update: Good news! It's actually installed already: Run Get-Command aws
Get-Command aws
aws --version
shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
env:
RUSTFLAGS: -Ctarget-feature=+crt-static
RUST_MIN_STACK: 16777216
CommandType Name Version Source
----------- ---- ------- ------
Application aws.exe 0.0.0.0 C:\Program Files\Amazon\AWSCLIV2\aws.exe
aws-cli/2.24.8 Python/3.12.6 Windows/11 exe/ARM64 https://github.com/rust-lang/rustup/actions/runs/14490128412/job/40644490076?pr=4290 |
3f9297f
to
3695807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our compatibility with Windows ARM64 seems to be quite good: the full test suite has passed for a few times in a row.
That's great to hear! I think for rustup problems with platform detection would be the main thing likely to be affected by an ARM64 host but it seems that's not an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@ChrisDenton Thanks for pointing that out; to be frank I'm not quite sure the platform detection is good though, it looks like when we install rustup in this CI everything is hardcoded, and I don't quite remember if we have tests on platform detection. That said, I've heard from a few users about their experience on ARM64 and I'm not aware of anything about that yet either. Update: Someone has obviously done that testing manually on their machine when adding support for ARM64 Windows: #3010 |
This takes advantage of the new (free) ARM64 Windows runners: https://blogs.windows.com/windowsdeveloper/2025/04/14/github-actions-now-supports-windows-on-arm-runners-for-all-public-repos/