Skip to content

Remove the cancel-outdated-builds action #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 14, 2024

This action was only used in Clippy, where I have removed its usage in rust-lang/rust-clippy#12477 (comment).

I think that we can remove it now, since it's supported natively by Github Actions using the concurrency group.

@Kobzol Kobzol requested a review from jdno March 14, 2024 11:47
Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action is still used in a lot of forks. Sadly all locked to @master. 🙈

But given that we don't seem to be using it within the rust-lang organization, I think it should be safe to remove.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 15, 2024

Okay, let's nuke it and see if anyone complains.

@Kobzol Kobzol merged commit ca5fbbc into rust-lang:master Mar 15, 2024
@Kobzol Kobzol deleted the remove-cancel-outdated-builds branch March 15, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants