Refactor part 5 #134
Merged
Refactor part 5 #134
+866
−851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And recv_with_flags and recv_out_of_band.
Also add Socket::recv_vectored.
And add Socket::recv_from_vectored_with_flags.
This changes it to call Socket::recv. On unix this would previously call read(2), but recv(2) without flags should have the same affect. Furthermore this implements io::Read::read_vectored by calling Socket::recv_vectored.
Socket::new, Socket::pair and Socket::accept now set close-on-exec flag on Unix, on Apple platforms SOCK_NOSIGPIPE and on Windows the socket is made non-inheritable. New Socket::new_raw, Socket::pair_raw and Socket::accept_raw functions are added which do not set the above flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
recvandsendand related functions, including theio::Readandio::Writeimplementations.Also changes the
Socket::new,Socket::pairandSocket::acceptfunctions to set close-on-exec flag on Unix, on Apple platformsSOCK_NOSIGPIPEand on Windows the socket is made non-inheritable. NewSocket::new_raw,Socket::pair_rawandSocket::accept_rawfunctions are added which do not set the above flags. This work as done by @de-vri-es in #117.