-
Notifications
You must be signed in to change notification settings - Fork 296
Open
Labels
Description
Steps for implementing an intrinsic:
- Select an intrinsic below
- Review
coresimd/arm/neon.rs
andcoresimd/aarch64/neon.rs
- Consult ARM official documentation about your intrinsic
- Consult godbolt for how the intrinsic should be codegen'd, using clang as an example. Use the links below and replace the name of the intrinsic in the code with your intrinsic. Note that if ARM is an error then your intrinsic may be AArch64-only
- If the codegen is the same on ARM/AArch64, place the intrinsic in
coresimd/arm/neon.rs
. If it's different place it in both with appropriate#[cfg]
incoresimd/arm/neon.rs
. If it's only AArch64 place it incoresimd/aarch64/neon.rs
- Write a test for your intrinsic at the bottom of the file as well
- Test! Probably use
rustup run nightly sh ci/run-docker.sh aarch64-unknown-linux-gnu
. - When ready, send a PR!
lain-dono, ohsayan, codehippo, boozook, fzyzcjy and 4 moreyisiblboozook and yisibl
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
gnzlbg commentedon Oct 24, 2017
stdsimd
too #460oconnor663 commentedon Nov 15, 2018
Is there a blocker for these, or is it just finding time to do it? I'd like to help, but I'd need a more experienced compiler/SIMD person to point me in the right direction.
gnzlbg commentedon Nov 15, 2018
I can mentor. Start by taking a look at some of the intrinsics in the
coresimd/aarch64/neon.rs
module :)oconnor663 commentedon Nov 16, 2018
Is there some upstream source that these all get copied from, or are they actually written by hand?
gnzlbg commentedon Nov 16, 2018
I am not sure I understand the question ? The
neon
modules in this repository are written by hand, although @Amanieu has expressed interest into generating some parts of them automatically.oconnor663 commentedon Nov 16, 2018
gnzlbg commentedon Nov 16, 2018
Ah, I see, that would be the ARM NEON spec: https://developer.arm.com/technologies/neon/intrinsics
alexcrichton commentedon Dec 20, 2018
Now might be a great time to help make some more progress on this! We've got tons of intrinsics already implemented (thanks @gnzlbg!), and I've just implemented automatic verification of all added intrinsics, so we know if they're added they've got the correct signature at least!
I've updated the OP of this issue with more detailed instructions about how to bind NEON intrinsics. Hopefully it's not too bad any more!
We'll probably want to reorganize modules so they're a bit smaller and more manageable over time, but for now if anyone's interested to add more intrinsics and needs some help let me know!
40 remaining items