Skip to content

Conversation

surechen
Copy link
Contributor

@surechen surechen commented Mar 8, 2021

add neon instruction vbsl
vbsl: Bitwise Select. This instruction sets each bit in the destination SIMD&FP register to the corresponding bit from the first source SIMD&FP register when the original destination bit was 1, otherwise from the second source SIMD&FP register.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Mar 8, 2021

Looking at the GCC/Clang headers it seems the p64 and f64 variants should also be available on ARM.

@surechen
Copy link
Contributor Author

surechen commented Mar 8, 2021

Looking at the GCC/Clang headers it seems the p64 and f64 variants should also be available on ARM.

Hi. Thanks for reviewing.
I use https://godbolt.org/ with clang to check this instruction.
https://godbolt.org/z/P7x1dv
https://godbolt.org/z/r3T68b
The result is Compilation failed.
If there is any problem with my verification method, please help me. Thank you very much.

@Amanieu
Copy link
Member

Amanieu commented Mar 8, 2021

Ah sorry you are correct, I misread the headers.

@Amanieu Amanieu merged commit 894f3b7 into rust-lang:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants