Skip to content

Fix the powerpc feature guards #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Mar 25, 2023

Now the documentation should be generated correctly and vsx isn't always present.

Now the documentation should be generated correctly and vsx isn't always
present.
@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2023

r? @Amanieu

(rustbot has picked a reviewer for you, use r? to override)

@Amanieu Amanieu merged commit c262de9 into rust-lang:master Mar 25, 2023
@Amanieu
Copy link
Member

Amanieu commented Apr 23, 2023

This seems to have broken portable-simd in #110285. Instead of putting a cfg on the entire module, these functions should instead always be available but unsafe, like the other arches: the user is responsible for performing feature detection before using the corresponding intrinsics, and the types should always be available.

@lu-zero
Copy link
Contributor Author

lu-zero commented Apr 23, 2023

I can prepare a PR for it.

@lu-zero lu-zero deleted the ppc-feature-guards branch April 23, 2023 16:58
lu-zero added a commit to lu-zero/stdarch that referenced this pull request Apr 23, 2023
Amanieu pushed a commit that referenced this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants