Rename wasm32 memory intrinsics
#560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnzlbg
reviewed
Sep 6, 2018
| #[rustc_deprecated(reason = "renamed to memory::size", since = "1.30.0")] | ||
| #[unstable(feature = "stdsimd", issue = "27731")] | ||
| #[allow(deprecated)] | ||
| #[doc(hidden)] |
There was a problem hiding this comment.
We should open an issue to delete these by some date (e.g. halloween).
The official name of the memory intrinsics has changed to `memory.size` and `memory.grow`, so let's reflect that with our naming as well! Additionally they have an argument of which memory to operate on with LLVM and must always be zero currently.
alexcrichton
force-pushed
the
rename-memory
branch
from
453cf1a to
6197dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official name of the memory intrinsics has changed to
memory.sizeandmemory.grow, so let's reflect that with our naming as well! Additionally theyhave an argument of which memory to operate on with LLVM and must always be zero
currently.