Skip to content

Remove usage of platform-intrinsics where unadjusted works #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

Remove usage of platform-intrinsics where unadjusted works #630

merged 1 commit into from
Jan 4, 2019

Conversation

alexcrichton
Copy link
Member

As suggested here!

gnzlbg
gnzlbg approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@gnzlbg gnzlbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is unadjusted required ? Doesn't extern { } just work ?

@alexcrichton
Copy link
Member Author

Unfortunately not because of the aggregate return, which needs to be a specific LLVM type that otherwise doesn't manifest as such (since tuples aren't ABI-safe)

@alexcrichton alexcrichton merged commit 7fea753 into rust-lang:master Jan 4, 2019
@alexcrichton alexcrichton deleted the no-platform branch January 4, 2019 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gnzlbg gnzlbg gnzlbg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrichton @gnzlbg