-
Notifications
You must be signed in to change notification settings - Fork 309
Add codegen-{cranelift,gcc}
marker teams for custom codegen backend ping groups
#1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why are we creating marker teams? We already have a wg-gcc-backend working group. I don't see one for cranelift, but we should do the same and create one instead of creating marker teams. |
For ping groups. You can't ping rust-lang/wg-gcc-backend if u're not an org member. |
Oh, the llvm one is actually for icebreakers-llvm and not wg-llvm. Fair enough. I still wish we didn't have to create marker teams. |
Oh I raced with ur comment here over at the r-l/r side PR lol. Yeah, I don't think you can use a real wg team as ping group. |
Friendly ping @rust-lang/team-repo-admins |
I don't think you can ping a marker group if you're not a team member, either. I'm not quite clear why these would be created. It sounds like Ralf couldn't remember the team names, but I'm not sure how you would remember the ping group names, either. Also you can just type |
Yes, the reason for the marker-group is so it can be registered through r-l/r triagebot, see for instance https://github.com/rust-lang/rust/blob/65899c06f117ddac9c8399479ddcdc122c92fddf/triagebot.toml#L49-L58. That way, non-org members can ping through triagebot via
This is not intended primarily for org members who can already ping The intention is not to "remember them", because they will be documented in rustc-dev-guide, and CI job failure logs can backlink to rustc-dev-guide dedicated test job/component pages (in this case, custom codegen backend pages) and/or dedicated ping group pages. See the r-l/r side companion PR rust-lang/rust#138120. |
FTR, I removed the |
See for example #347 which adds a "windows" marker-team for r-l/r side triagebot ping group. |
I'm pretty sure only team members can ping: https://github.com/rust-lang/triagebot/blob/d45a79f6a37a9cbd84b4160a13020f7dacf9f3f3/src/handlers/ping.rs#L28-L35 |
... Wait, what? |
Ok thank you, I had no idea that was the specific case. Then this is entirely useless. |
Part of rust-lang/rust#138116.
Discussion: #t-infra > Triagebot ping groups for GCC and cranelift backends.
rust-lang/rust side triagebot configuration + docs: rust-lang/rust#138120
cc @GuillaumeGomez @bjorn3 @antoyo