Skip to content

Updates favicon, adds missing assets #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2020
Merged

Updates favicon, adds missing assets #23

merged 2 commits into from
Jul 16, 2020

Conversation

sl4m
Copy link

@sl4m sl4m commented Jul 15, 2020

This PR does several things:

  • adds missing assets defined in container.hbs
  • introduces a dark mode compatible SVG favicon. Same favicon from this PR: Updates favicons to support dark mode www.rust-lang.org#1185
  • removes favicon.ico reference from container.hbs as that will take precedence.
  • re-arranges the order of favicons as Chrome appears to apply "last favicon wins"

@pietroalbini
Copy link
Member

Thanks!

@pietroalbini pietroalbini merged commit 6b29750 into rust-lang:master Jul 16, 2020
@sl4m sl4m deleted the update-favicon branch January 13, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sl4m @pietroalbini