Skip to content

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jun 17, 2025

So it looks like this, instead of this.

Kind-of related, looking at both our check-commits warnings and this error, I'm wondering if we should use GitHub UI warning and error block.

@Urgau Urgau requested a review from Kobzol June 17, 2025 21:43
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the block would be more visually distinctive, but I wouldn't put the whole message in it, just some header (e.g. warnings detected).

@Kobzol Kobzol added this pull request to the merge queue Jun 18, 2025
Merged via the queue into rust-lang:master with commit 2407f13 Jun 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants