-
Notifications
You must be signed in to change notification settings - Fork 94
Zulip stream type check #2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Zulip stream type check #2150
Conversation
Failed to set assignee to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me, but I haven't tested it, so I will let others take a look otherwise I will merge in the next few days.
thanks! Testing this is a bit tedious, but I will do that in the next couple of days @rustbot author |
subject: Option<String>, | ||
/// The type of the message: stream or private. | ||
#[allow(unused)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notice that I also removed the "unused" attribute introduced in 41a793d
ddeb6f3
to
6765f22
Compare
6765f22
to
0c03e13
Compare
Hmm waiting on the Zulip folks to reply to a question because my tests seems to indicate that Zulip still sends the old payload. If true, this patch would break everything so I'll put it into draft status to be sure it's not merged. |
The Zulip Message API has changed a little bit since we implemented our client. This patch:
type
.tbh these changes are not really necessary but slightly improve the correctness of our client.
For anyone who has an opinion :)