Misc changes for our range-diff #2160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
commented
Aug 16, 2025
| Ok(()) | ||
| } | ||
|
|
||
| async fn post_new_comment( |
There was a problem hiding this comment.
I don't like that this logic is here.
I would prefer if it was shared with the other check-commits sub-handlers, but given the requirement of only hiding the previous comment when posting a new one, which is different from all the others sub-handler, it's was simpler to do it here rather than increasing the complexity in check-commits.
There was a problem hiding this comment.
I guess that in theory we could add the logic to the shared "check commits result" comment, but for now this is fine.
Urgau
force-pushed
the
gh-range-diff-misc-2
branch
from
7b9a858 to
6ebc414
Compare
Kobzol
approved these changes
Aug 17, 2025
| Ok(()) | ||
| } | ||
|
|
||
| async fn post_new_comment( |
There was a problem hiding this comment.
I guess that in theory we could add the logic to the shared "check commits result" comment, but for now this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some changes regarding our range-diff feature:
#t-compiler/help > ✔ rustbot tells me my PR was rebased on a different master