Skip to content

align rustc and chalk folder type #31

@nikomatsakis

Description

@nikomatsakis
Contributor
  • chalk's folder is fallible and has a Result, rustc does not
  • chalk's folder is generic over the type family

Activity

nikomatsakis

nikomatsakis commented on May 18, 2021

@nikomatsakis
Author
rustbot

rustbot commented on May 18, 2021

@rustbot
nikomatsakis

nikomatsakis commented on May 18, 2021

@nikomatsakis
ContributorAuthor
LeSeulArtichaut

LeSeulArtichaut commented on May 18, 2021

@LeSeulArtichaut
nikomatsakis

nikomatsakis commented on May 19, 2021

@nikomatsakis
ContributorAuthor

(cc @rust-lang/release -- any tips on how to make the triagebot work :)

Mark-Simulacrum

Mark-Simulacrum commented on May 19, 2021

@Mark-Simulacrum
Member

(Triagebot should work now, fixed the permissions).

eggyal

eggyal commented on Nov 25, 2021

@eggyal

I understand from rust-lang/rust#85485 (comment) that @LeSeulArtichaut isn't able to work on these at present. Would it be okay if I have a crack at moving them forward? I've already opened rust-lang/rust#91230 to pick up where rust-lang/rust#85469 left off.

@rustbot claim

eggyal

eggyal commented on Nov 28, 2021

@eggyal

With rust-lang/rust#91230 merged, the first of these actions can be marked complete.

removed their assignment
on Jun 6, 2022
eggyal

eggyal commented on Feb 5, 2023

@eggyal

The second action here had me confused for a while, until I spotted that TypeFamily was renamed Interner in rust-lang/chalk#329.

eggyal

eggyal commented on Feb 14, 2023

@eggyal

With rust-lang/rust#107924 merged, rustc's folder is also now generic over the Interner (formerly Type Family).

And since chalk is no longer to be integrated with rustc, I guess further alignment of the folder types is not required?

jackh726

jackh726 commented on Feb 14, 2023

@jackh726
Member

Well, how are they still different? Might give some clues on if the rustc folder traits should be modified for some future solver state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @nikomatsakis@eggyal@Mark-Simulacrum@jackh726@LeSeulArtichaut

        Issue actions

          align rustc and chalk folder type · Issue #31 · rust-lang/types-team