-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Description
- chalk's folder is fallible and has a
Result
, rustc does notTo pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.chalk's folder is generic over the type familyTo pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Activity
nikomatsakis commentedon May 18, 2021
rustbot commentedon May 18, 2021
nikomatsakis commentedon May 18, 2021
@rustbot assign @LeSeulArtichaut
LeSeulArtichaut commentedon May 18, 2021
nikomatsakis commentedon May 19, 2021
(cc @rust-lang/release -- any tips on how to make the triagebot work :)
Mark-Simulacrum commentedon May 19, 2021
(Triagebot should work now, fixed the permissions).
eggyal commentedon Nov 25, 2021
I understand from rust-lang/rust#85485 (comment) that @LeSeulArtichaut isn't able to work on these at present. Would it be okay if I have a crack at moving them forward? I've already opened rust-lang/rust#91230 to pick up where rust-lang/rust#85469 left off.
@rustbot claim
eggyal commentedon Nov 28, 2021
With rust-lang/rust#91230 merged, the first of these actions can be marked complete.
eggyal commentedon Feb 5, 2023
The second action here had me confused for a while, until I spotted that
TypeFamily
was renamedInterner
in rust-lang/chalk#329.eggyal commentedon Feb 14, 2023
With rust-lang/rust#107924 merged, rustc's folder is also now generic over the Interner (formerly Type Family).
And since chalk is no longer to be integrated with rustc, I guess further alignment of the folder types is not required?
jackh726 commentedon Feb 14, 2023
Well, how are they still different? Might give some clues on if the rustc folder traits should be modified for some future solver state