note on uninhabited structs #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should not be a note IMO (it's not just clarifying something or a digression, it's on the same level as the preceding paragraph) but otherwise LGTM. |
gnzlbg
reviewed
Oct 21, 2019
Better now? |
hanna-kruppe
approved these changes
Oct 21, 2019
|
@gnzlbg are you okay with merging this? |
|
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized that our current wording excludes making
(i32, !)zero-sized. That's currently true and there are good arguments for keeping it that way, but we have no guarantee yet.