Remove Media Guide #1656
Remove Media Guide #1656
Conversation
The canonical logo policy and media guide is now hosted on the Rust Foundation website https://foundation.rust-lang.org/policies/logo-policy-and-media-guide/
|
It should still be linked from the website, no? |
|
Ah yes, fair enough. The same is done for the Privacy Policy. Will fix. |
|
This still removes the translated link text. Only the policy should be removed and the link target should be updated |
|
Can redirect(s) be added to prevent broken links? www.rust-lang.org/src/redirect.rs Lines 45 to 56 in 2d803d6 |
@Manishearth What would the translated link text be used for though if the policy is not on the actual rust-lang.org site? I agree the translated link text will actually be useful if and when the Foundation gets around to translating the site - we could use that translated text as a starting point. |
|
@JoelMarcey I'm not talking about the translated policy text, I'm talking about the link text in the footer: your PR switches everyone to English |
|
@Manishearth Oh. Well, I just followed the precedent that was done for the Privacy Policy link change. That changes everyone to English too, right? 56/files#diff-d3d64205c4a28105d6051690404ca37daca8f1e4cedf52669e6cf60acc570649R25 Unless I am still misunderstanding what you are referring to. |
|
Yeah sounds like that was a mistake too. I'll fix it when I'm back on a computer The footers of each translated website should be in that language, even if they link to English content |
|
I fixed it for the privacy policy: #1657 |
locales/en-US/policies.ftl
Outdated
| @@ -7,7 +7,6 @@ policies-page-description = This page links to the comprehensive set of Rust’s | |||
|
|
|||
| policies-code-of-conduct-link = Code of Conduct | |||
| policies-licenses-link = Licenses | |||
| policies-media-guide-link = Logo Policy and Media Guide | |||
There was a problem hiding this comment.
Basically, these entries shoudl not be removed
| @@ -12,9 +12,9 @@ | |||
| <ul> | |||
| <li><a href="{{baseurl}}/policies/code-of-conduct">{{fluent "policies-code-of-conduct-link"}}</a></li> | |||
| <li><a href="{{baseurl}}/policies/licenses">{{fluent "policies-licenses-link"}}</a></li> | |||
| <li><a href="{{baseurl}}/policies/media-guide">{{fluent "policies-media-guide-link"}}</a></li> | |||
There was a problem hiding this comment.
and only the URLs, not the link text, should be updated here
| <li><a href="{{baseurl}}/policies/security">{{fluent "policies-security-link"}}</a></li> | ||
| <li><a href="{{baseurl}}/policies/privacy">{{fluent "policies-privacy-link"}}</a></li> |
There was a problem hiding this comment.
this bit still needs to be fixed
|
Sorry if I missed this in the documentation somewhere, but when does this pull request get merged to the live rust-lang.org site? I saw it was in the staging site. Does it coincide with the next release of the language? Thanks! cc @abibroom |
|
A pull request to the deploy branch needs to be done, after reviewing the staging site. I'm pretty busy these days and most of the other people involved in the website aren't that active so it's not something that occurs regularly; but you can ask for a deploy any time (or make the PR yourself). I'm doing it here: #1660 |
|
Thanks @Manishearth for helping me understand that it is not an automatic process and for kicking off a deploy as well. |
|
Yeah, it used to be automatic, but it was easy to break the website, so there's a manual review step now and we only deploy occasionally. |
The canonical logo policy and media guide is now hosted on the Rust Foundation website
https://foundation.rust-lang.org/policies/logo-policy-and-media-guide/
Fixes #1655