Skip to content

Use new NativeWindow::lock() API in dummy_render() #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use new NativeWindow::lock() API in dummy_render() #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e73bd8
Use new `NativeWindow::lock()` API in `dummy_render()`
MarijnS95 Jun 23, 2023
58cf377
DRAFT: Make compatible with `android-activity 0.5.0-beta.1` release
MarijnS95 Aug 26, 2023
455ddd6
Lints
MarijnS95 Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions agdk-cpal/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name = "agdk-cpal"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
log = "0.4"
android_logger = "0.11.0"
Expand All @@ -15,4 +13,4 @@ anyhow = "1"

[lib]
name="main"
crate_type=["cdylib"]
crate_type=["cdylib"]
2 changes: 1 addition & 1 deletion agdk-cpal/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ fn android_main(app: AndroidApp) {
redraw_pending = false;

// Handle input
app.input_events(|event| {
app.input_events_iter().unwrap().next(|event| {
info!("Input Event: {event:?}");
InputStatus::Unhandled
});
Comment on lines -150 to 153
Copy link
Member Author

@MarijnS95 MarijnS95 Aug 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rib this next() function returns a bool. Are we supposed to run it in a while loop, and if so can you put that in the doc-comment and give this function #[must_use] to make it (much!) harder to overlook?

Expand Down
4 changes: 1 addition & 3 deletions agdk-eframe/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ version = "0.1.0"
edition = "2021"
resolver = "2"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
log = "0.4"
winit = { version = "0.28", features = [ "android-game-activity" ] }
Expand All @@ -32,4 +30,4 @@ crate_type=["cdylib"]
[[bin]]
path="src/lib.rs"
name="agdk-eframe"
required-features = [ "desktop" ]
required-features = [ "desktop" ]
4 changes: 1 addition & 3 deletions agdk-egui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ version = "0.1.0"
edition = "2021"
resolver = "2"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
log = "0.4"
pollster = "0.2"
Expand Down Expand Up @@ -37,4 +35,4 @@ required-features = [ "desktop" ]
#[patch.crates-io]
#egui = { version = "0.22", path = "../../egui/crates/egui" }
#egui-wgpu = { version = "0.22", path = "../../egui/crates/egui-wgpu" }
#egui-winit = { version = "0.22", path = "../../egui/crates/egui-winit" }
#egui-winit = { version = "0.22", path = "../../egui/crates/egui-winit" }
Loading