Skip to content

Fix SVD without u or vt #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 19, 2019
Merged

Fix SVD without u or vt #163

merged 6 commits into from
Jun 19, 2019

Conversation

termoshtt
Copy link
Member

Resolve #162

termoshtt added 4 commits June 19, 2019 15:18
@termoshtt
Add test for SVD without u or vt
2c787f5
@termoshtt
Generate tests using paste crate
48c2106
@termoshtt
Fix leading dimensions
9ca911e 
LAPACK document says
> The leading dimension of the array U.  LDU >= 1; if JOBU = 'S' or 'A'
@termoshtt
Bug fix of ldvt
44821c9
@termoshtt termoshtt marked this pull request as ready for review June 19, 2019 19:29
@termoshtt termoshtt merged commit afe38d4 into master Jun 19, 2019
@termoshtt termoshtt deleted the bugfix_svd_162 branch June 19, 2019 20:11
@joshgev
Copy link

joshgev commented Jun 19, 2019

Thanks a lot, @termoshtt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong parameter 10 in LAPACKE_sgesvd_work
2 participants
@termoshtt @joshgev