Fix covariance of zero-observation arrays and corresponding test #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dot product should be all zeros, and the `dof` is `0. - (-1.) = 1.`, so all elements in the result should be `0. / 1. = 0.`. This matches the result from NumPy.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrixmultiply(used byndarrayfor matrix multiplication) has a bug that results in uninitialized memory being returned if the matrices being multiplied have shapesm × 0and0 × n. This PR adds a patch to fix this (bluss/matrixmultiply#21). It also fixestest_covariance_zero_observationsto test that all elements are zero.