Skip to content

macros: update string interning #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Nov 28, 2016

No description provided.

@cuviper
Copy link
Member Author

cuviper commented Nov 28, 2016

However, note this warning:

warning: `#[derive]` for custom traits is deprecated and will be removed in v1.15. Prefer using procedural macro custom derive
  --> tests/test_macro.rs:16:28
   |
16 | #[derive(Debug, PartialEq, NumFromPrimitive)]
   |                            ^^^^^^^^^^^^^^^^

So this is something of a last gasp for num-macros, and we'll have to kill it soon.

@hauleth
Copy link
Member

hauleth commented Nov 28, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Nov 28, 2016

📌 Commit 7ebef5b has been approved by hauleth

homu added a commit that referenced this pull request Nov 28, 2016
macros: update string interning

None
@homu
Copy link
Contributor

homu commented Nov 28, 2016

⌛ Testing commit 7ebef5b with merge ee452a1...

@homu
Copy link
Contributor

homu commented Nov 28, 2016

💔 Test failed - status

@cuviper
Copy link
Member Author

cuviper commented Nov 28, 2016

failed to fetch `https://github.com/rust-lang/crates.io-index`
[16/-17] The SSL certificate is invalid

?!?

@homu retry

homu added a commit that referenced this pull request Nov 28, 2016
macros: update string interning

None
@homu
Copy link
Contributor

homu commented Nov 28, 2016

⌛ Testing commit 7ebef5b with merge 4e43555...

@homu
Copy link
Contributor

homu commented Nov 28, 2016

💔 Test failed - status

@hauleth
Copy link
Member

hauleth commented Nov 28, 2016

Strange

@homu retry

@homu
Copy link
Contributor

homu commented Nov 28, 2016

⌛ Testing commit 7ebef5b with merge 5474d3b...

homu added a commit that referenced this pull request Nov 28, 2016
macros: update string interning

None
@homu
Copy link
Contributor

homu commented Nov 28, 2016

💔 Test failed - status

@cuviper
Copy link
Member Author

cuviper commented Nov 28, 2016

My own testing used the same as the initial Travis build here:

$ rustc --version
rustc 1.15.0-nightly (2217bd771 2016-11-25)
$ cargo --version
cargo 0.16.0-nightly (b26d672 2016-11-25)

The failing homu builds are using:

$ rustc --version
rustc 1.15.0-nightly (03bdaade2 2016-11-27)
$ cargo --version
cargo 0.16.0-nightly (3568be9 2016-11-26)

I updated locally, and now I see the same SSL errors. :(

@cuviper
Copy link
Member Author

cuviper commented Dec 2, 2016

@homu retry

homu added a commit that referenced this pull request Dec 2, 2016
macros: update string interning

None
@homu
Copy link
Contributor

homu commented Dec 2, 2016

⌛ Testing commit 7ebef5b with merge a63bbc9...

@homu
Copy link
Contributor

homu commented Dec 2, 2016

☀️ Test successful - status

@homu homu merged commit 7ebef5b into rust-num:master Dec 2, 2016
@cuviper cuviper deleted the intern-macros branch January 11, 2017 23:41
remexre pushed a commit to remexre/num that referenced this pull request Jun 1, 2017
Generalize json! macro to ToJson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants