Added trait From<T> for Ratio<T> where T: Clone + Integer #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, looks reasonable to me. Could you add a quick test somewhere? Perhaps in |
|
Added. |
|
Should I rebase? |
|
I guess you mean squash -- but no, I don't mind if the PR has multiple commits. Nightly CI is broken right now due to rust-lang/cargo#3340, but that should be resolved when a new nightly comes out, so I'm just going to wait on merging for a clean CI run. |
cuviper
approved these changes
Dec 1, 2016
homu
added a commit
that referenced
this pull request
Dec 2, 2016
Added trait From<T> for Ratio<T> where T: Clone + Integer Hi! So I thought that this kind of trait would be useful when one wants to write code which should be generic over different types of numbers.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
So I thought that this kind of trait would be useful when one wants to write code which should be generic over different types of numbers.