[Logger] Don't panic if unsupported char #256
Conversation
| let bitmap_char = get_bitmap(c, FontWeight::Regular, BitmapHeight::Size14).unwrap(); | ||
| let bitmap_char = get_bitmap(c, FontWeight::Regular, BitmapHeight::Size14) | ||
| .unwrap_or( | ||
| get_bitmap('■', FontWeight::Regular, BitmapHeight::Size14).unwrap() |
There was a problem hiding this comment.
Maybe � (Replacement Character)?
There was a problem hiding this comment.
What are you referring? � it's not in the noto-sans-mono-bitmap crate yet.
There was a problem hiding this comment.
it's not in the noto-sans-mono-bitmap crate yet.
Really? I would have expected it to be. Guess it is fine to leave it like this.
There was a problem hiding this comment.
Really? I would have expected it to be. Guess it is fine to leave it like this.
Maintainer here: I'm about to add more unicode ranges as selectable cargo features. Thus, it will be available soon, hopefully. Currently, this specific symbol is not included.
However, having a reliable default as fall back is important and a good. One can argue whether this should be a space or the ■, tho
There was a problem hiding this comment.
tho... What?
There was a problem hiding this comment.
Sorry, I never listened that. I'm from Spain and English in Spain is quite bad.
Thanks, now I have one word more.
There was a problem hiding this comment.
@bjorn3 So we merge it with the ■, or we wait for the other char (�) which is more descriptive?
There was a problem hiding this comment.
Update regarding unicode features in the noto-sans-mono-bitmap crate: I experimented with it but even adding a "reasonable amount" of unicode ranges results in a 12 GB large crate, as all the characters must be pre-rasterized and shipped with the crate.
This is unacceptable. I decided that noto-sans-mono-bitmap has to strive for minimality. If you want the whole unicode range @asensio-project , switch to user-mode in your kernel project and use the floating point unit for dynamic font rendering. You will be able to use dynamic rendering of all the chars you can think of.
I'll keep you updated when I have something release-ready
There was a problem hiding this comment.
OK, I will create a PR for adding the � char to noto-sans-mono-bitmap-rs and then we can merge it for the main branch and the next branch of the bootloader. @phip1611
|
I opened #267 to bump the |
|
Closing this in favor of #267. |
Hello,
Currently, when we print a char in the screen if it is unsupported on noto-sans-mono-bitmap it panics.
Now the noto-sans-mono-bitmap supports the '■' char, we can use it instead of panicking.
Changes included in this PR:
- Update noto-sans-mono-bitmap (Cargo.toml)
- Don't panic if an unsupported char is found (src/binary/logger.rs)
Thanks!