Use build-std-features instead of rlibc #298
Merged
+4
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've built a UEFI application with this library this year and it worked great, thank you!
But there's one thing I've noticed in the test-runner and in the application template:
uefi-rs/uefi-test-runner/Cargo.toml
Lines 14 to 17 in 229da01
So, I wondered, why not directly enable the mem feature of compiler-builtins? It seems to work both in my application and in the test-runner, so I thought, I'd submit this as a PR. If there's something I'm missing, feel free to close this PR. :)
There's one last thing about the BUILDING.md I stumbled upon while creating this PR, but it's not really important:
uefi-rs/BUILDING.md
Line 27 in d289e0c
Why is the command line that long?
-Z build-std
is already specified in.cargo/config
, so it's not really needed. (The same applies to-Z build-std-features=compiler-builtins-mem
.)