Add PXE Base Code protocol #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if the failed CI run is caused by the changes made in this pr, I get the same error on the main branch on my machine. |
|
Thanks for the PR! I am also seeing the i686 compilation failure, filed #418 to fix that. |
| @@ -0,0 +1,116 @@ | |||
| use uefi::{ | |||
There was a problem hiding this comment.
No substantive comment, just wanted to mention I appreciate the nice test here :)
nicholasbishop
approved these changes
May 1, 2022
There was a problem hiding this comment.
lgtm -- I'll leave to @GabrielMajeri to merge in case he has any additional comments.
GabrielMajeri
approved these changes
May 7, 2022
|
Would it be possible to publish a new version? I have a pr for https://github.com/rust-osdev/bootloader that depends on this. |
|
@Freax13 Sure! Will work on making a new release as soon as possible. |
|
@Freax13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the PXE Base Code protocol.
I only need
BaseCode::tftp_get_file_sizeandBaseCode::tftp_read_file, but felt weird about only adding a small part of the protocol, so added the other functions as well.I was able to test
BaseCode::tftp_get_file_sizeandBaseCode::tftp_read_fileon real hardware.This pr slightly overlaps with #306: Both prs add structures for
EFI_MAC_ADDRESSandEFI_IP_ADDRESS.