Skip to content

Rename global_allocator module and change scope of global_allocator feature #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

nicholasbishop
Copy link
Member

The global_allocator module has been renamed to allocator, and is now available regardless of whether the global_allocator feature is enabled. The global_allocator feature now only controls whether allocator::Allocator is set as Rust's global allocator.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
Copy link
Member Author

@phip1611 re #563 (comment), does this change meet your needs?

The `global_allocator` feature now only controls whether the
`#[global_allocator]` attribute is set on `Allocator`; the `Allocator` itself is
now always available.
@phip1611 phip1611 force-pushed the bishop-alloc-api-changes branch from c88304f to 8045d43 Compare March 24, 2023 18:41
@phip1611
Copy link
Member

Love it, nice!

@phip1611 phip1611 merged commit 349f7de into rust-osdev:main Mar 24, 2023
@nicholasbishop nicholasbishop deleted the bishop-alloc-api-changes branch March 25, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants