Allow indexing of MemoryMap.
#966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the contribution. I'll have a closer look in a couple of hours. |
phip1611
reviewed
Oct 18, 2023
phip1611
reviewed
Oct 18, 2023
|
Please add a note about the API change to |
phip1611
reviewed
Oct 19, 2023
`MemoryMap`. Added corresponding tests as well.
nicholasbishop
approved these changes
Oct 24, 2023
|
I went ahead and fixed the git conflict in the changelog, merging now. Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In developing a bootloader for my microkernel, I have have found that being able to index the given
MemoryMapwould reduce some complexity.