Ensure that Page actually implements Hash #490
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Looks good to me, thanks!
I'm not 100% sure whether this is a breaking change or not. I can never remember if adding a trait is one or not. I am happy to rebase this onto next. Should be a trivial change anyways.
We run semver checks in CI and they seem to pass :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page<S>only implementsHashifSalso implementsHash. Not sure why this is a requirement sincesizeis aPhantomData.This PR adds
Hashimplementations forSize4KiB,Size2MiBandSize1GiB.I'm not 100% sure whether this is a breaking change or not. I can never remember if adding a trait is one or not. I am happy to rebase this onto next. Should be a trivial change anyways.