Reenable cross build/link tests and update cross #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My not caching the build results, we should hopefuly prevent the linking errors we were seeing before. Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
newpavlov
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build/link tests were failing due to certain libraries not being present. This was fixed in Cross version 0.2.5: cross-rs/cross#1166
Earlier, I had thought these tests were failing because of improperly cached builds. However, I was wrong, the failures were due to a missing library..
Fixes #329
This also moves our Web Tests to Ubuntu 22.04, as that image now has Firefox: actions/runner-images#6528
Signed-off-by: Joe Richey [email protected]